Skip to content

hdl: remove Memory. #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Jun 14, 2024

Fixes #1083.

@wanda-phi wanda-phi requested a review from whitequark as a code owner June 14, 2024 23:21
@whitequark whitequark enabled auto-merge June 14, 2024 23:26
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (5c51afd) to head (7e0e25d).
Report is 4 commits behind head on main.

Current head 7e0e25d differs from pull request most recent head 6a3da1f

Please upload reports for the commit 6a3da1f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   91.16%   91.07%   -0.09%     
==========================================
  Files          43       43              
  Lines       11113    11006     -107     
  Branches     2712     2392     -320     
==========================================
- Hits        10131    10024     -107     
+ Misses        812      807       -5     
- Partials      170      175       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark whitequark added this pull request to the merge queue Jun 14, 2024
auto-merge was automatically disabled June 14, 2024 23:29

Head branch was pushed to by a user without write access

@wanda-phi wanda-phi force-pushed the remove-hdl-memory branch from 7e0e25d to 6a3da1f Compare June 14, 2024 23:29
@whitequark whitequark removed this pull request from the merge queue due to a manual request Jun 14, 2024
@whitequark whitequark enabled auto-merge June 14, 2024 23:29
@whitequark whitequark added this pull request to the merge queue Jun 14, 2024
Merged via the queue into amaranth-lang:main with commit e7aaf60 Jun 14, 2024
20 checks passed
@wanda-phi wanda-phi deleted the remove-hdl-memory branch June 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for RFC 45: Move hdl.Memory to lib.Memory
2 participants