Skip to content

hdl._nir: add combinational cycle detection. #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2024
Merged

hdl._nir: add combinational cycle detection. #1330

merged 1 commit into from
Apr 13, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #704.
Fixes #1143.

@wanda-phi wanda-phi requested a review from whitequark as a code owner April 13, 2024 11:40
whitequark
whitequark reviewed Apr 13, 2024
View reviewed changes
whitequark
whitequark reviewed Apr 13, 2024
View reviewed changes
whitequark
whitequark reviewed Apr 13, 2024
View reviewed changes
whitequark
whitequark reviewed Apr 13, 2024
View reviewed changes
whitequark
whitequark requested changes Apr 13, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@wanda-phi wanda-phi force-pushed the cycle branch 3 times, most recently from c424d03 to c2801aa Compare April 13, 2024 13:53
whitequark
whitequark approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whitequark whitequark enabled auto-merge April 13, 2024 13:54
@codecov Codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.60%. Comparing base (8bf4f77) to head (0ff4649).
Report is 1 commits behind head on main.

Files Patch % Lines
amaranth/hdl/_nir.py 97.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1330      +/-   ##
==========================================
+ Coverage   90.55%   90.60%   +0.05%     
==========================================
  Files          43       43              
  Lines       10718    10830     +112     
  Branches     2617     2648      +31     
==========================================
+ Hits         9706     9813     +107     
- Misses        831      835       +4     
- Partials      181      182       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark whitequark added this pull request to the merge queue Apr 13, 2024
Merged via the queue into amaranth-lang:main with commit 877a106 Apr 13, 2024
@wanda-phi wanda-phi deleted the cycle branch April 13, 2024 14:09
@widlarizer
Copy link
Contributor

Sweet!

@whitequark whitequark added this to the 0.5 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

infinite loop in NIR builder on a trivial comb loop Detect and reject netlists with combinatorial loops
3 participants
@wanda-phi @widlarizer @whitequark