Document RFC 62 #1294
Merged
Document RFC 62 #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
force-pushed
the
memorydata-docs
branch
from
efd39c9 to
33d2e22
Compare
wanda-phi
approved these changes
Apr 9, 2024
whitequark
force-pushed
the
memorydata-docs
branch
2 times, most recently
from
258d8eb to
5207b5d
Compare
This includes a few minor code changes: - Removing redundant `lib.memory.Memory.Init = hdl.MemoryData.Init` re-export; - Renaming `FrozenError` to `FrozenMemory` and moving it to `.hdl`; - Marking `ReadPort` and `WritePort` as `@final`.
whitequark
force-pushed
the
memorydata-docs
branch
from
5207b5d to
ca404a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few minor code changes:
lib.memory.Memory.Init = hdl.MemoryData.Initre-export;FrozenErrortoFrozenMemoryand moving it to.hdl;ReadPortandWritePortas@final.