Skip to content

hdl._mem: implement MemoryData._Row from RFC 62. #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

wanda-phi
Copy link
Member

No description provided.

@wanda-phi wanda-phi requested a review from whitequark as a code owner April 3, 2024 15:14
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 73.64865% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 89.63%. Comparing base (f71bee4) to head (4a56232).
Report is 1 commits behind head on main.

Files Patch % Lines
amaranth/sim/pysim.py 32.00% 14 Missing and 3 partials ⚠️
amaranth/hdl/_dsl.py 85.54% 8 Missing and 4 partials ⚠️
amaranth/sim/_pyeval.py 61.53% 2 Missing and 3 partials ⚠️
amaranth/hdl/_mem.py 86.36% 2 Missing and 1 partial ⚠️
amaranth/sim/core.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   89.88%   89.63%   -0.26%     
==========================================
  Files          44       44              
  Lines       10325    10417      +92     
  Branches     2510     2548      +38     
==========================================
+ Hits         9281     9337      +56     
- Misses        844      871      +27     
- Partials      200      209       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark enabled auto-merge April 3, 2024 17:10
@whitequark whitequark added this pull request to the merge queue Apr 3, 2024
Merged via the queue into amaranth-lang:main with commit 767d69c Apr 3, 2024
19 of 20 checks passed
@wanda-phi wanda-phi deleted the memory-row branch April 3, 2024 17:25
@whitequark whitequark added this to the 0.5 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants