Skip to content

hdl._mem: add MemoryData class. #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

wanda-phi
Copy link
Member

This implements half of RFC 62. The MemoryData._Row class will be implemented later, as a follow-up.

@wanda-phi wanda-phi requested a review from whitequark as a code owner April 2, 2024 12:46
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 89.78%. Comparing base (1deaf70) to head (bc04b8f).

Files Patch % Lines
amaranth/sim/pysim.py 62.85% 10 Missing and 3 partials ⚠️
amaranth/hdl/_mem.py 97.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1256      +/-   ##
==========================================
- Coverage   89.80%   89.78%   -0.03%     
==========================================
  Files          43       43              
  Lines       10008    10055      +47     
  Branches     2426     2439      +13     
==========================================
+ Hits         8988     9028      +40     
- Misses        823      831       +8     
+ Partials      197      196       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This implements half of RFC 62. The `MemoryData._Row` class will be
implemented later, as a follow-up.
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark added this pull request to the merge queue Apr 2, 2024
Merged via the queue into amaranth-lang:main with commit 09d5540 Apr 2, 2024
20 checks passed
@wanda-phi wanda-phi deleted the mem-data branch April 2, 2024 15:48
@whitequark whitequark added this to the 0.5 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants