-
Notifications
You must be signed in to change notification settings - Fork 178
Implement RFC 45: Move hdl.Memory
to lib.Memory
.
#1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
+ Coverage 85.61% 85.87% +0.26%
==========================================
Files 42 43 +1
Lines 8433 8675 +242
Branches 1998 2065 +67
==========================================
+ Hits 7220 7450 +230
- Misses 1016 1024 +8
- Partials 197 201 +4 ☔ View full report in Codecov by Sentry. |
110391f
to
23f7f2e
Compare
23f7f2e
to
c12d30a
Compare
8664285
to
2255cb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we decide to get rid of MemoryIdentity
in the end?
I ended up including it, since this allows us to recognize memories of all kinds (old and new) as "something that has an Still not sure if this is the way to go. |
288f2c2
to
302fdc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you back out the docs rst file? I'd like to improve these before publishing, but I don't want to block the PR on that.
302fdc5
to
93554fd
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #216.