hdl._ast: fix using 0-width Switch with integer keys.
#1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanda-phi
force-pushed
the
switch-0-width-int
branch
from
80f28f6 to
9bd16ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
=======================================
Coverage 85.47% 85.48%
=======================================
Files 42 42
Lines 8358 8362 +4
Branches 1973 1975 +2
=======================================
+ Hits 7144 7148 +4
- Misses 1017 1018 +1
+ Partials 197 196 -1 ☔ View full report in Codecov by Sentry. |
This comes up in `AssignmentLegalizer`-produced `Switch`es for `ArrayProxy`.
wanda-phi
force-pushed
the
switch-0-width-int
branch
from
9bd16ac to
c06fd12
Compare
whitequark
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes up in
AssignmentLegalizer-producedSwitches forArrayProxy.