Handle non-IndexError failures in graph and summary updates - #296
Merged
amanusk merged 1 commit intoAug 5, 2026
Merged
Conversation
update_displayed_information() guards source.update() against any recoverable exception, but the graph and summary rendering loops only caught IndexError. Any other exception raised while a widget redrew (TypeError/ValueError/OSError from a shape mismatch or transient UI state) propagated out of the urwid alarm callback and terminated the application. Both loops now apply the same policy already used for source updates: log and continue in normal runtime, re-raise in debug mode. Adds tests/test_view_update_errors.py covering both loops for TypeError/ValueError/OSError plus the debug-mode re-raise. Closes amanusk#258
Owner
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258.
update_displayed_information()catches any recoverable exception fromsource.update(), but the graph and summary loops only caughtIndexError, so aTypeError/ValueError/OSErrorraised while a widget redrew propagated out of the urwid alarm callback and killed the app. Both loops now follow the same policy as the source loop: log and continue in normal runtime, re-raise in debug mode.New
tests/test_view_update_errors.pyfails 6/7 without the change and passes 7/7 with it.