Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/en prefix bug does not allow parameters #578

Closed
parceldetect opened this issue Oct 24, 2023 · 4 comments · Fixed by #149
Closed

/en prefix bug does not allow parameters #578

parceldetect opened this issue Oct 24, 2023 · 4 comments · Fixed by #149
Labels
bug Something isn't working unconfirmed Needs triage.

Comments

@parceldetect
Copy link

parceldetect commented Oct 24, 2023 •
edited
Loading

Description

When trying to access /en as parameters for example /en?source=google, it gives an error.

Screenshot_276

I've tried everything and I don't know how to solve this.

Mandatory reproduction URL (CodeSandbox or GitHub repository)

(exemple with bug)
Screenshot_277

https://codesandbox.io/p/sandbox/next-intl-bug-template-forked-yow8ep

Reproduction description

Steps to reproduce:

  1. enter url /en
  2. add params /en?source=google
  3. redirected you too many times.

Expected behaviour

redirect to /?source=google or allow /en?source=google
@parceldetect parceldetect added bug Something isn't working unconfirmed Needs triage. labels Oct 24, 2023
@amannn
Copy link
Owner

amannn commented Oct 24, 2023

Thanks for the report! This is already fixed in the 3.0 release candidate: #569

@amannn amannn mentioned this issue Oct 24, 2023
Merged
@parceldetect
Copy link
Author

Thanks for the report! This is already fixed in the 3.0 release candidate: #569

Thanks for responding more when trying to use the fixed version, I have error with "import Link from "next-intl/link""

Screenshot_279

@amannn
Copy link
Owner

amannn commented Oct 24, 2023

Please carefully read through the release notes: https://next-intl-docs.vercel.app/blog/next-intl-3-0

@parceldetect
Copy link
Author

Please carefully read through the release notes: https://next-intl-docs.vercel.app/blog/next-intl-3-0

Thanks @amannn

amannn added a commit that referenced this issue Nov 14, 2023
@amannn @wxh06
@Tobi-mmt @CptCompiler @jlalmes @BrendonSled
feat!: next-intl@3.0 (#149)
50cf6bb 
→ Please refer to [the
announcement](https://next-intl-docs.vercel.app/blog/next-intl-3-0)


Fixes #488
Fixes #402
Fixes #578

---------

Co-authored-by: 汪心禾 <wangxinhe06@gmail.com>
Co-authored-by: Tobias <tobi.l@posteo.at>
Co-authored-by: Andres <CptCompiler@users.noreply.github.com>
Co-authored-by: Andres <andres@21st.digital>
Co-authored-by: narakhan <narakhan@users.noreply.github.com>
Co-authored-by: Nicholas Mobbs <nick.mobbs@apporetum.dev>
Co-authored-by: James Berry <69924001+jlalmes@users.noreply.github.com>
Co-authored-by: Brendon Sled <brendon@tinyroar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working unconfirmed Needs triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Next.js 13 RSC integration amannn/next-intl
2 participants
@amannn @parceldetect