Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

least/greatest improvement: Limiter #264

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Conversation

ArthurGazizov
Copy link
Contributor

@ArthurGazizov ArthurGazizov commented Oct 19, 2022

I really liked your implementation of the Limiter, just added small optimization. When current Limiter is in initial state and we want to putAll items from other limiter, we can do system array copy if space is enough. Result will be the same as if just call put method for each element

@ArthurGazizov
Copy link
Contributor Author

@amaembo could you please help me a little bit with error, seems to me it doesn’t relate to commit🙂

Error: Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project streamex: Build error: Either repository token or service with job id must be defined -> [Help 1]

@amaembo
Copy link
Owner

amaembo commented Oct 20, 2022

Yes, it doesn't. Please ignore it.

@amaembo amaembo merged commit 7f22178 into amaembo:master Oct 22, 2022
@amaembo
Copy link
Owner

amaembo commented Oct 22, 2022

Thanks.

@amaembo amaembo added this to the 0.8.2 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants