feat: add --wait-interval flag and DBMATE_WAIT_INTERVAL env var - #803
Open
somaz94 wants to merge 1 commit into
Open
feat: add --wait-interval flag and DBMATE_WAIT_INTERVAL env var#803somaz94 wants to merge 1 commit into
somaz94 wants to merge 1 commit into
Conversation
somaz94
marked this pull request as ready for review
June 23, 2026 01:36
Author
|
Gentle nudge, @amacneil — it's been a few weeks. This adds a --wait-interval flag / DBMATE_WAIT_INTERVAL env for the wait command; it's opt-in and defaults preserve the current behavior. Happy to adjust anything. Thanks for dbmate! |
Author
|
Open since June with no review. Is a configurable wait interval ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--wait-intervalCLI flag andDBMATE_WAIT_INTERVALenv var to configure the delay between connection attempts for--wait. TheWaitIntervalfield is already exposed to Go API users; this plumbs it through the CLI, mirroring the existing--wait-timeout/DBMATE_WAIT_TIMEOUT.Validation (local, macOS):
go build ./...andgo vet ./...passgolangci-lint run: 0 issuesgo testfor the main package passes, including a newTestConfigureDB_WaitInterval(default / env / flag-overrides-env)dbmate --helpshows:--wait-interval value ... (default: 1s) [$DBMATE_WAIT_INTERVAL]related: #516