enable passing nothing as data #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces code duplication; also annotate types of ctor args now samples(SemObsCov) returns nothing
add observed_vars(data::SemObserved)
* use SemObsMissingPattern struct to
simplify code
* replace O(Nvars^2) common pattern detection
with Dict{}
* don't store row-wise, store sub-matrices
of non-missing data instead
* use StatsBase.mean_and_cov()
StatsBase.mean_and_cov() is used instead
to match the update data preparation behaviour
to specify the prefix of the generated observed_vars if none provided could be inferred, defaults to :obs
Co-authored-by: Maximilian Ernst <34346372+Maximilian-Stefan-Ernst@users.noreply.github.com>
alyst
force-pushed
the
enhance_data_import
branch
from
e16d68f to
673aa2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.