-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): 🐛 Enable GPL on linux build and remove AppImage from CI #2056
Conversation
daf846c
to
a59a714
Compare
Yeah it likes to fail on alvr_packets for some reason |
Sry for asking but why removing AppImages? They worked just fine for me on nvidia. |
I'm interested in why as well. |
AppImages weren't required anymore (almost everything is bundled into alvr as static library now, appimage reason for being portable is nulled at this point) and it was maintenance burden that no one knew how to properly maintain, thus it was removed as unnecessary. |
Hey, so I am trying to run the linux build and its crashing. I am not sure why, but this did not happen with the appimage. Is there a way to figure what is missing in the native build? |
@guysoft please open new issue and provide output of |
… CI (alvr-org#2056)" This reverts commit a0fe143.
@Meister1593 for the same reason please remove flatpack, as the exact same logic applies |
Flatpak is made fairly differently but removing flatpak build is planned as well. Just need to update instructions how to use with tar instead of it. It might be also possible to use it with nvidia that way. |
Updating that my issue was fixed. I am now using the static build which works for me. |
Same deal as on nightlies
Merge only after it gets tested at least on nightlies, otherwise i don't know if it works on nvidia (double-checking removal of nc-codec-headers)