fix(dashboard): 🐛 Use steam uri handler instead of xdg-open and error if linux SteamVR files are missing. #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if linux SteamVR files are missing.
|
|
zmerp
approved these changes
Mar 25, 2024
Vixea
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to using
steambinary instead ofxdg-openbecause it caused issues if you have multiple steams.Nothing asks which steam to use and alvr launches first one configured somehow, and created UB on most systems with multiple steams. I checked using regular
steaminside flatpak and it seemed to work just fine.Also made simple check for SteamVR files for situations where someone set proton as compatibility tool (deliberately, or accidentally), or steam did something wrong and assumed windows version of steamvr needed to be installed.
Without that check it just says some file doesn't exist without any clues, so i think that's a good change over that.