Encode in full range color for NvEncoder on H264/HEVC #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests showed that there is no easy way to make this work on android headsets (Quest, Pico etc). So we need at least a comment (in the setting name or help tooltip) saying that it only works on Nvidia + Apple Vision Pro. |
|
I disagree since we're just going to merge my pr soon after |
|
(just the nvidia part the Apple Vision Pro part is ok) |
|
@shinyquagsire23 the full range fix on the Android side needs to be applied conditionally. Or just don't fix it at all and let's assume full range doesn't work |
zmerp
approved these changes
Mar 2, 2024
Vixea
approved these changes
Mar 2, 2024
galister
pushed a commit
to galister/ALVR
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple, 2 line fix, verified on visionOS client