Support AV1 encoding using AMF on Windows #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vixea
requested changes
Jan 26, 2024
|
I think this PR should be split between AMF headers upgrade and the rest, because the changes are hard to navigate. |
IMO it's not hard to navigate. Why would you split PR if it all related? Unless the headers upgrade is not required for the rest. |
|
If anything else, i'd like to split the PR because of the "single concern" principle. |
|
^ it would be much easier to figure out what the issue is if an upgrade of the headers happens to cause issues however unlikely |
Vixea
reviewed
Feb 4, 2024
Merged
|
I think the PR can be rebased @barnabwhy |
barnabwhy
force-pushed
the
av1-win-amf
branch
from
0155769 to
ae18cf2
Compare
|
Does AV1 also work on Windows with Nvidia cards? 🤔 |
|
@MommasLittleHelper Noone contributed that yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be working nicely from my testing with a Quest 3 and RX 7700XT.
There's a couple of changes to settings, namely:
With this I also updated AMF to v1.4.33, which may bring some improvements elsewhere. (It may be worth looking into the "New AVC / HEVC encoder rate control methods" added in v1.4.28)