Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial handshake failure blocking retries #1942

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix initial handshake failure blocking retries #1942

merged 1 commit into from
Jan 2, 2024

Conversation

The-personified-devil
Copy link
Collaborator

When initially establishing the connection, if the handshake packet from the client doesn't arrive the client stays registered as connecting and thus retries become impossible. Adb creates a listen socket immediately upon enabling port forwarding. Because the socket gets accepted the server attempts to establish a connection and fails because adb on it's own won't send the handshake packet when the client's not running, thus blocking retries and preventing a connection being made when the client is actually started.

Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you so much! I will merge this as is but you uncovered a pretty big flaw in the connection design: retries will fail if the connection gets interrupted any time during handshake.

@zmerp zmerp merged commit fd6ca7d into alvr-org:master Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants