Fix initial handshake failure blocking retries #1942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initially establishing the connection, if the handshake packet from the client doesn't arrive the client stays registered as connecting and thus retries become impossible. Adb creates a listen socket immediately upon enabling port forwarding. Because the socket gets accepted the server attempts to establish a connection and fails because adb on it's own won't send the handshake packet when the client's not running, thus blocking retries and preventing a connection being made when the client is actually started.