-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard and settings minor rehearsal #1893
Conversation
Could you split this PR into one for each feature? or at least move the foveated encoding refactor to another PR as it's dominating regarding the number of changes. |
669e145
to
563c978
Compare
Done #1894 |
LGTM 👍 |
Actually I just noticed something disable adaptive framerate not sure how I feel about that one as it should've been fixed, so is not needed |
9644be2
to
92e4791
Compare
2f2e748
to
e9058bd
Compare
…ling gestures on wiki. Small rename for older names for only touch in setup wizard.
i reverted that change, it didn't seem to affect it anymore. I'm not 100% certain if it's completely fixed on high bitrate cabled, but i couldn't test that anyway on master, so i would leave it as is for now. |
I'm going to clean up a bit with platform-specific checks (clippy complains) and i think it will be done |
Also looks like the unix module import needs to be cfg guarded |
…to not even show unnecessary buttons for platfo rms.
Question, should i consider all the platform checks/stuff for macos as well? (like, right now it will show vb cable for windows on macos) |
nevermind, i need to do them anyway otherwise it won't even build on macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and remove whitespaces at line 4 and 10 😅
hey, here from the stable version. For some reason, pipewire doesn't show up in my audio options. I am on manjaro linux, and i have pipewire installed. |
This PR is unrelated to any audio options, i would create separate issue for this instead of writing here. |
oops sorry |
Added Setup page for enabling hand tracking gestures toggle
Added Donate to Open Collective hyperlink in About tab
Updated setup page with software requirements (added linux audio auto setup)
Updated wiki page for hand tracking gestures, distrobox guide.
Updated default sharpening to 0.5 (significantly improves quality for basically free)
Removed Dynamic oculus foveation toggle (was completely unused in codebase, was replaced with client foveation options)