generated from alvarobartt/python-package-template
-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Overall improvements, bug fixes, more unit tests, and dm-haiku
compatibility tested
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it works with JAX and Haiku too, not just Flax. So we're extending `safejax` use-cases.
Already tested with both `flax` and `haiku` models out of the box, so `safejax` is out of `0.2.0.dev0` :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Features
flax.py
intosave.py
,load.py
, andutils.py
for readabilitysave.py
containsserialize
load.py
containsdeserialize
utils.py
contains bothflatten_dict
andunflatten_dict
freeze_dict
param tounflatten_dict
to either convert it toFrozenDict
or keep it as aDict
(used forflax
)pytest
to cover everysafejax
functiondm-haiku
model param serialization overhaiku.nets.ResNet50
examples/
for bothflax
anddm-haiku
🐛 Bug Fixes
unflatten_dict
due to a variable being overwritten🧪 Tests
If the above checkbox is checked, describe how you unit-tested it.
safejax.utils.flatten_dict
andsafejax.utils.unflatten_dict
work as expected to avoid bug mentioned above withunflatten_dict
safejax.load
andsafejax.save
due to the recent split of both files