Hide hour indicator when it's out of day bounds #106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui-ant
commented
Mar 16, 2022
| > | ||
| <span | ||
| class="line" | ||
| v-show="kalendar_options.style === 'material_design'" | ||
| ></span> | ||
| <!-- kalendar_options.style === 'material_design' && passedTimeVisible --> |
gui-ant
changed the title
gui-ant
changed the title
|
@guiantz I am not sure I understand the issue. How can day be out of bounds ? Can you do a codesandbox reproduction of the issue ? |
|
The issue occurs when you define a partial period of day (e.g. 13pm-16pm) and the calendar is rendered on a time out of that interval (e.g. 12pm). This makes function passedTime() returning null, what will cause an exception when the position of the timeline is calculated. On the demo sample the available hours are defined to all day, so this issue never occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to and possibly closes issue #52:
The
passedTime()function was returning null when current time was out of day bounds. So,distanceprop was not exists.Changed to return the same
{distance, time}object, but with distance value as -1.Hour line is shown only when passes
passedTimeVisibleguard, added as computed prop.