Add 500 retry codes and associated unit tests. (microsoft#1003)

Co-authored-by: Jackson Weber <jacksonweber@microsoft.com>
altinokdarici · Aug 18, 2022 · e0d2ad4 · e0d2ad4
1 parent 34208e4
commit e0d2ad4
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 2 deletions.
diff --git a/Library/Sender.ts b/Library/Sender.ts
@@ -358,7 +358,9 @@ class Sender {
             statusCode === 408 || // Timeout
             statusCode === 429 || // Too many requests
             statusCode === 500 || // Server Error
-            statusCode === 503 // Server Unavailable
+            statusCode === 502 || // Bad Gateway
+            statusCode === 503 || // Server Unavailable
+            statusCode === 504 // Gateway Timeout
         );
     }
 

diff --git a/Tests/Library/Sender.tests.ts b/Tests/Library/Sender.tests.ts
@@ -101,7 +101,7 @@ describe("Library/Sender", () => {
             });
         });
 
-        it("should put telemetry in disk when retryable code is returned", (done) => {
+        it("should put telemetry in disk when retryable 408 code is returned", (done) => {
             var envelope = new Contracts.Envelope();
             envelope.name = "TestRetryable";
             nockScope = interceptor.reply(408, null);
@@ -113,6 +113,54 @@ describe("Library/Sender", () => {
             });
         });
 
+        it("should put telemetry in disk when retryable 500 code is returned", (done) => {
+            var envelope = new Contracts.Envelope();
+            envelope.name = "TestRetryable";
+            nockScope = interceptor.reply(500, null);
+            var storeStub = sandbox.stub(sender, "_storeToDisk");
+            sender.send([envelope], (responseText) => {
+                assert.ok(storeStub.calledOnce);
+                assert.equal(storeStub.firstCall.args[0][0].name, "TestRetryable");
+                done();
+            });
+        });
+
+        it("should put telemetry in disk when retryable 502 code is returned", (done) => {
+            var envelope = new Contracts.Envelope();
+            envelope.name = "TestRetryable";
+            nockScope = interceptor.reply(502, null);
+            var storeStub = sandbox.stub(sender, "_storeToDisk");
+            sender.send([envelope], (responseText) => {
+                assert.ok(storeStub.calledOnce);
+                assert.equal(storeStub.firstCall.args[0][0].name, "TestRetryable");
+                done();
+            });
+        });
+
+        it("should put telemetry in disk when retryable 503 code is returned", (done) => {
+            var envelope = new Contracts.Envelope();
+            envelope.name = "TestRetryable";
+            nockScope = interceptor.reply(503, null);
+            var storeStub = sandbox.stub(sender, "_storeToDisk");
+            sender.send([envelope], (responseText) => {
+                assert.ok(storeStub.calledOnce);
+                assert.equal(storeStub.firstCall.args[0][0].name, "TestRetryable");
+                done();
+            });
+        });
+
+        it("should put telemetry in disk when retryable 504 code is returned", (done) => {
+            var envelope = new Contracts.Envelope();
+            envelope.name = "TestRetryable";
+            nockScope = interceptor.reply(504, null);
+            var storeStub = sandbox.stub(sender, "_storeToDisk");
+            sender.send([envelope], (responseText) => {
+                assert.ok(storeStub.calledOnce);
+                assert.equal(storeStub.firstCall.args[0][0].name, "TestRetryable");
+                done();
+            });
+        });
+
         it("should retry only failed events in partial content response", (done) => {
             var breezeResponse: Contracts.BreezeResponse = {
                 itemsAccepted: 2,