Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from frozendict to immutabledict #90

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Switch from frozendict to immutabledict #90

merged 1 commit into from
Jul 29, 2020

Conversation

alexhenrie
Copy link
Contributor

frozendict is broken on the latest versions of Python and the project is dead, see slezica/python-frozendict#30

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #90 into master will increase coverage by 0.52%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   80.38%   80.91%   +0.52%     
==========================================
  Files          28       28              
  Lines        2565     2635      +70     
  Branches      471      471              
==========================================
+ Hits         2062     2132      +70     
  Misses        379      379              
  Partials      124      124              
Impacted Files Coverage Δ
pronto/relationship.py 76.32% <50.00%> (ø)
pronto/term.py 82.66% <100.00%> (ø)
pronto/parsers/rdfxml.py 69.08% <0.00%> (+0.07%) ⬆️
pronto/utils/meta.py 71.42% <0.00%> (+0.31%) ⬆️
pronto/parsers/obojson.py 88.00% <0.00%> (+0.50%) ⬆️
pronto/parsers/obo.py 86.36% <0.00%> (+0.64%) ⬆️
pronto/parsers/_fastobo.py 92.33% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c370293...fc6b2ef. Read the comment docs.

@althonos
Copy link
Owner

Thanks for the heads-up, didn't know frozendict was not maintained anymore!

Ultimately we'll probably have to implement a custom collections.abc.Mapping to store the relationships for a Term or a Relationship as discussed briefly in #89 .

@althonos althonos merged commit 337d6ab into althonos:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants