Skip to content

Remove constants.py #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Remove constants.py #243

merged 2 commits into from
Jan 29, 2023

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Jan 27, 2023

I think we can remove this file because none of the remaining primitives seem to make use of it. An updated version of the file with additional definitions lives in Featuretools as well.

@sbadithe sbadithe changed the title Remove constants.py Remove constants.py Jan 27, 2023
@sbadithe sbadithe marked this pull request as ready for review January 28, 2023 00:01
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #243 (f6e9231) into main (22588fc) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   98.53%   98.53%   -0.01%     
==========================================
  Files          27       26       -1     
  Lines         683      682       -1     
==========================================
- Hits          673      672       -1     
  Misses         10       10              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni merged commit c17eb62 into main Jan 29, 2023
@gsheni gsheni deleted the remove-constants branch January 29, 2023 19:33
@gsheni gsheni mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants