Skip to content

Remove readthedocs and docs requirements #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 15, 2022
Merged

Remove readthedocs and docs requirements #193

merged 11 commits into from
Aug 15, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Aug 10, 2022

@gsheni gsheni changed the title Update .readthedocs.yaml Remove readthedocs and docs requirements Aug 10, 2022
@gsheni gsheni self-assigned this Aug 10, 2022
@gsheni gsheni requested a review from rwedge August 10, 2022 20:04
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #193 (06c6d8b) into main (23814b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          53       53           
  Lines        1391     1391           
=======================================
  Hits         1381     1381           
  Misses         10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni marked this pull request as ready for review August 10, 2022 20:29
@rwedge
Copy link
Contributor

rwedge commented Aug 10, 2022

Should we delete the docs folder and have a changelog.rst / changelog.md in the root directory?

@gsheni
Copy link
Contributor Author

gsheni commented Aug 10, 2022

@rwedge good point. Fixed

@gsheni gsheni enabled auto-merge (squash) August 11, 2022 14:34
@gsheni gsheni requested review from rwedge and sbadithe and removed request for rwedge August 11, 2022 14:35
Copy link
Contributor

@sbadithe sbadithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the docs from .gitignore as well?

@gsheni gsheni disabled auto-merge August 15, 2022 15:19
@gsheni gsheni merged commit 3d90d16 into main Aug 15, 2022
@gsheni gsheni deleted the fix_docs branch August 15, 2022 15:19
@thehomebrewnerd thehomebrewnerd mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants