Migrate to setup.cfg #127
Migrate to setup.cfg #127
Conversation
| @@ -20,18 +20,13 @@ jobs: | |||
| run: | | |||
| python -m virtualenv venv_core | |||
| source venv_core/bin/activate | |||
| python -m pip install --upgrade pip | |||
| python -m pip install -r requirements.txt | |||
| python -m pip install -r test-requirements.txt | |||
There was a problem hiding this comment.
only dependencies being tracked in latest_core_dependencies.txt are nltk and featuretools which are both regular requirements so not necessary to install the test requirements (which also install the complete requirements)
There was a problem hiding this comment.
We should also update the make package_nlp_primitives command to use python -m build instead of python setup.py sdist. See Featuretools for reference: https://github.com/alteryx/featuretools/blob/54c2ba8a80193f0b05f271fd493fd7c90fc34f82/Makefile#L48
| @@ -0,0 +1 @@ | |||
| __version__ = '2.5.0' | |||
There was a problem hiding this comment.
Now that we have added this file, should we add a test_version.py file like we have in other repos?
Also, we need to update release.md to point to the proper places where the version needs to be changed: here and in test_version.py if we add that. Don't need to refer to setup.py any more.
setup.cfg
Outdated
| tensorflow_hub >= 0.4.0 | ||
|
|
||
| dev = | ||
| wheel>=0.35.1 |
There was a problem hiding this comment.
Is wheel needed? I know it was in the deps before, but not clear why off the top of my head.
There was a problem hiding this comment.
probably not, I imagine build would replace it as a direct need at this point if anything
| license = BSD 3-clause | ||
| long_description = file: README.md | ||
| long_description_content_type = text/markdown | ||
| url = https://github.com/alteryx/nlp_primitives |
There was a problem hiding this comment.
Maybe we should update the URL's like in Featuretools to include some other links?
https://github.com/alteryx/featuretools/blob/54c2ba8a80193f0b05f271fd493fd7c90fc34f82/setup.cfg#L6
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
|
I can approve this once the tests pass. |
Closes #114
Also has more steps in the CI use Make commands instead of using pip directly