Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readthedocs and deps fixes #4177

Merged
merged 12 commits into from
May 8, 2023
Merged

Readthedocs and deps fixes #4177

merged 12 commits into from
May 8, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented May 8, 2023

Closes #4180

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #4177 (1d5b2fe) into main (bef373a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4177   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      37797   37797           
=====================================
  Hits       37680   37680           
  Misses       117     117           

@eccabay eccabay marked this pull request as ready for review May 8, 2023 20:21
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eccabay eccabay enabled auto-merge (squash) May 8, 2023 20:23
@eccabay eccabay requested a review from cp2boston May 8, 2023 20:51
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job team!

@eccabay eccabay merged commit ee540f1 into main May 8, 2023
@eccabay eccabay deleted the rtd_and_deps_fixes branch May 8, 2023 22:53
@chukarsten chukarsten mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix readthedocs
4 participants