allow adding '%' to volume command#358
Open
m4rch3n1ng wants to merge 3 commits intoaltdesktop:masterfrom
Open
Conversation
when passing an empty string to `playerctl volume` it would then try to read `len - 1`, which would be `-1`, which would be an invalid index
allows things like `playerctl 45%`, which would be equivalent to `playerctl 0.45`, and `playerctl 5%+`, which would be equivalent to `playerctl 0.05+`.
4c267e7 to
ccde3f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now parses options such as
playerctl volume 45%(which is equivalent toplayerctl volume 0.45) andplayerctl volume 5%+(which is equivalent toplayerctl volume 0.05+)as a drive-by fix in [aa558c5] also avoid a heap-buffer overflow, as it was reading from index -1 when the string was empty (i.e. when calling
playerctl volume ""). when running with asan, i got this error before this pr: