sway: pango markup not fully supported (span rendered as plain text) #157

Activity

1. CastixGitHub

   added

   bug

   on Jun 21, 2020
2. CastixGitHub

   assigned

   acrisci

   on Jun 21, 2020
3. acrisci commented on Aug 30, 2020

   

   acrisci

   on Aug 30, 2020

   Member

   More actions

   I wonder if it has something to do with how sway unescapes those quotes. You don't have quote escapes in the example that works and that probably makes a difference.
4. CastixGitHub commented on Aug 31, 2020

   

   CastixGitHub

   on Aug 31, 2020

   Author

   More actions

   well, you are right

   anyway, on i3 if I do

   >>> vars(i3.command('rename workspace i: work to <span foreground=\"blue\">blue</span>')[0])
   {'ipc_data': {'success': False, 'parse_error': True, 'error': "Expected one of these tokens: 'to'", 'input': 'rename workspace i: work to <span foreground="blue">blue</span>', 'errorposition': '                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'}, 'success': False, 'error': "Expected one of these tokens: 'to'"}
   
   >>> vars(i3.command('rename workspace "i: work" to <span foreground=\"blue\">blue</span>')[0])
   {'ipc_data': {'success': True}, 'success': True, 'error': None}
   # worked
   >>> vars(i3.command('rename workspace "i: work" to <span foreground="blue">blue</span>')[0])
   {'ipc_data': {'success': True}, 'success': True, 'error': None}
   # worked

   so i need to quote before to (now immagine doing the reverse):

   >>> vars(i3.command('rename workspace <span foreground="blue">blue</span> to i: work')[0])
   {'ipc_data': {'success': False, 'parse_error': True, 'error': "Expected one of these tokens: 'to'", 'input': 'rename workspace <span foreground="blue">blue</span> to i: work', 'errorposition': '                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'}, 'success': False, 'error': "Expected one of these tokens: 'to'"}
   >>> vars(i3.command('rename workspace <span foreground="blue">blue</span> to "i: work"')[0])
   {'ipc_data': {'success': False, 'parse_error': True, 'error': "Expected one of these tokens: 'to'", 'input': 'rename workspace <span foreground="blue">blue</span> to "i: work"', 'errorposition': '                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'}, 'success': False, 'error': "Expected one of these tokens: 'to'"}
   >>> vars(i3.command('rename workspace "<span foreground="blue">blue</span>" to "i: work"')[0])
   {'ipc_data': {'success': False, 'parse_error': True, 'error': "Expected one of these tokens: 'to'", 'input': 'rename workspace "<span foreground="blue">blue</span>" to "i: work"', 'errorposition': '                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'}, 'success': False, 'error': "Expected one of these tokens: 'to'"}
   >>> vars(i3.command('rename workspace "<span foreground=\"blue\">blue</span>" to "i: work"')[0])
   {'ipc_data': {'success': False, 'parse_error': True, 'error': "Expected one of these tokens: 'to'", 'input': 'rename workspace "<span foreground="blue">blue</span>" to "i: work"', 'errorposition': '                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'}, 'success': False, 'error': "Expected one of these tokens: 'to'"}
   >>> vars(i3.command('rename workspace "<span foreground=\\"blue\\">blue</span>" to i: work')[0])
   {'ipc_data': {'success': True}, 'success': True, 'error': None}

   if I do the same with sway, if I do \\"blue\\" or \"blue\" I see the literal <span in the bar. to make it become blue, i have to remove \ but then, if I press the button on the bar, a new workspace named as the literal <span is created 🤕 so I cannot access to it anymore until I rename it (but opposite to i3 i can't quote the input argument (the part before to) otherwise it says There is no workspace with that name)

   so do you agree it should work with:

   vars(i3.command('rename workspace "i: work" to <span foreground=\\"blue\\">blue</span>')[0])

   on i3 and with

   vars(i3.command('rename workspace i: work to <span foreground="blue">blue</span>')[0])

   on sway, then there is that click issue with sway... (swaywm/sway#5652)
   is this inconsintency about quotes before to something i'm wrong or should be reported to sway devs too?
5. acrisci commented on Aug 31, 2020

   

   acrisci

   on Aug 31, 2020

   Member

   More actions

   Consider using raw strings to reduce confusion about the escapes.

   If there are any differences about escaped values in the parser, you can report it on sway because it's supposed to be compatible with the i3 config.