Add deb linux target to eletron-builder #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏾Thanks for opening this pull request! Please check out our contributing guidelines.👊🏾😁 |
Collaborator
|
Hello @dannysofftie thanks for the PR. However the changes here will cause the snap target from being compiled as well. I will need to take a closer look at this to ensure current target configurations aren't affected. |
Contributor
Author
|
Greatly appreciated. Reach out if you need me to make any changes |
Collaborator
|
I'll probably update this PR with the changes myself |
Contributor
Author
|
That works for sure. Much appreciated |
|
Congrats on merging your first pull request! 🙌🏾🎉🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Checks
yarn test-buildChanges proposed in this pull request:
Add support for Linux deb to electron-builder