Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme and responsiveness fixes #509

Merged
merged 24 commits into from
Feb 20, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
2b00280
Dark themed cards
veedata Dec 13, 2021
7fafe35
Responsiveness fixes
veedata Dec 16, 2021
e205de3
added dark stylesheet option
veedata Dec 18, 2021
e51adcc
highlight theme toggle
veedata Dec 18, 2021
d95bffd
added highlight function
veedata Dec 20, 2021
ee7cb76
added highlight themes to assets/css
veedata Dec 22, 2021
45565db
offline highlight implementation
veedata Dec 22, 2021
5679a08
Merge branch 'alshedivat:master' into theme-fixes
veedata Dec 30, 2021
8dae833
Merge branch 'master' of https://github.com/veedata/al-folio into the…
veedata Dec 31, 2021
ef5b5d1
Fixes for masonry
veedata Jan 3, 2022
dc337af
Revert "added highlight themes to assets/css"
rohandebsarkar Jan 5, 2022
9c85d2e
Update `code syntax highlighting` to use jsdelivr CDN
rohandebsarkar Jan 5, 2022
3649c1c
Merge pull request #1 from rohandebsarkar/pr/veedata/509
veedata Jan 8, 2022
07cd5cf
Merge branch 'theme-fixes' of https://github.com/veedata/al-folio int…
veedata Jan 11, 2022
d716285
Merge branch 'alshedivat:master' into theme-fixes
veedata Jan 16, 2022
6952101
Merge branch 'theme-fixes' of https://github.com/veedata/al-folio int…
veedata Jan 16, 2022
b6d8a82
Project card responsiveness fixes
veedata Jan 16, 2022
fc0b694
Merge branch 'alshedivat:master' into theme-fixes
veedata Jan 20, 2022
5ba34cf
Merge branch 'alshedivat:master' into theme-fixes
veedata Jan 22, 2022
4a1a550
added personal website to readme
veedata Jan 24, 2022
c03f61a
Merge branch 'master' of https://github.com/alshedivat/al-folio into …
veedata Jan 31, 2022
e63edaf
Reverted responsiveness chnages
veedata Jan 31, 2022
c07f9af
Merge branch 'master' of https://github.com/alshedivat/al-folio into …
veedata Feb 18, 2022
500e0ff
Minor adjustments
alshedivat Feb 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ news_limit: 5
# Markdown and syntax highlight
markdown: kramdown
highlighter: rouge
highlight_theme: github # https://github.com/jwarby/jekyll-pygments-themes
highlight_theme_light: github # https://github.com/jwarby/jekyll-pygments-themes
highlight_theme_dark: native # https://github.com/jwarby/jekyll-pygments-themes
kramdown:
input: GFM
syntax_highlighter_opts:
Expand Down
4 changes: 3 additions & 1 deletion _includes/head.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<link rel="stylesheet" type="text/css" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Roboto+Slab:100,300,400,500,700|Material+Icons">

<!-- Code Syntax Highlighting -->
<link rel="stylesheet" href="https://gitcdn.link/repo/jwarby/jekyll-pygments-themes/master/{{ site.highlight_theme }}.css" />
<link rel="stylesheet" href="https://gitcdn.link/repo/jwarby/jekyll-pygments-themes/master/{{ site.highlight_theme_light }}.css" media="none" id="highlight_theme_light" />
veedata marked this conversation as resolved.
Show resolved Hide resolved

<!-- Styles -->
{% if site.icon != empty %}
Expand All @@ -45,6 +45,8 @@

{% if site.enable_darkmode %}
<!-- Dark Mode -->
<link rel="stylesheet" href="https://gitcdn.link/repo/jwarby/jekyll-pygments-themes/master/{{ site.highlight_theme_dark }}.css" media="none" id="highlight_theme_dark" />
veedata marked this conversation as resolved.
Show resolved Hide resolved

<script src="{{ '/assets/js/theme.js' | relative_url }}"></script>
<script src="{{ '/assets/js/dark_mode.js' | relative_url }}"></script>
{% endif %}
2 changes: 1 addition & 1 deletion _includes/projects.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="grid-item">
<div>
{% if project.redirect %}
<a href="{{ project.redirect }}">
{% else %}
Expand Down
3 changes: 1 addition & 2 deletions _pages/projects.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,13 @@ horizontal: false
</div>
</div>
{% else %}
<div class="grid">
<div class="card-columns">
{% for project in sorted_projects %}
{% include projects.html %}
{% endfor %}
</div>
{% endif %}
{% endfor %}

{% else %}
<!-- Display projects without categories -->
{% assign sorted_projects = site.projects | sort: "importance" %}
Expand Down
43 changes: 24 additions & 19 deletions _sass/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,30 @@ blockquote {
text-align: center;
}

// Card

.card {
background-color: var(--global-card-bg-color);

img {
width: 100%;
}

.card-title {
color: var(--global-text-color);
}

.card-item {
width: auto;
margin-bottom: 10px;

.row {
display: flex;
align-items: center;
}
}
}

// Citation
.citation, .citation-number {
color: var(--global-theme-color);
Expand Down Expand Up @@ -341,25 +365,6 @@ footer.sticky-bottom {
}
}

.card {
img {
width: 100%;
}
.card-title {
color: $black-color;
}
}

.card-item {
width: auto;
margin-bottom: 10px;

.row {
display: flex;
align-items: center;
}
}

.grid-item {
width: 250px;
margin-bottom: 10px;
Expand Down
2 changes: 2 additions & 0 deletions _sass/_themes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
--global-footer-link-color: #{$white-color};
--global-distill-app-color: #{$grey-color};
--global-divider-color: rgba(0,0,0,.1);
--global-card-bg-color: #{$white-color};

.fa-sun {
display : none;
Expand All @@ -37,6 +38,7 @@ html[data-theme='dark'] {
--global-footer-link-color: #{$black-color};
--global-distill-app-color: #{$grey-color-light};
--global-divider-color: #424246;
--global-card-bg-color: #{$grey-900};

.fa-sun {
padding-left: 10px;
Expand Down
1 change: 1 addition & 0 deletions _sass/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ $yellow-color: #efcc00 !default;
$grey-color: #828282 !default;
$grey-color-light: lighten($grey-color, 40%);
$grey-color-dark: #1C1C1D;
$grey-900: #212529;

$white-color: #ffffff !default;
$black-color: #000000 !default;
Expand Down
12 changes: 12 additions & 0 deletions assets/js/theme.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ let toggleTheme = (theme) => {

let setTheme = (theme) => {
transTheme();
setHighlight(theme);

if (theme) {
document.documentElement.setAttribute("data-theme", theme);
}
Expand All @@ -28,6 +30,16 @@ let setTheme = (theme) => {
}
};

let setHighlight = (theme) => {
if (theme == "dark") {
document.getElementById("highlight_theme_light").media = "none";
document.getElementById("highlight_theme_dark").media = "";
} else {
document.getElementById("highlight_theme_dark").media = "none";
document.getElementById("highlight_theme_light").media = "";
}
}


let transTheme = () => {
document.documentElement.classList.add("transition");
Expand Down