Added quora and medium to social #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks for the contribution! Minor: could you also add placeholders for the quora and medium variables to medium_username: # your Medium username
quora_username: # your Quora username |
|
Yes absolutely! I missed that, I'll do that by tomorrow.
Regards,
Mayank
…On Thu, Feb 21, 2019, 3:35 PM Maruan ***@***.***> wrote:
Looks great, thanks for the contribution!
Minor: could you also add placeholders for the quora and medium variables
to _config.yml in the Social integration section?
medium_username: # your Medium usernamequora_username: # your Quora username
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3ZCovXSgBVkK6Znr_JCOReonLsCctNks5vPwMjgaJpZM4bIO_P>
.
|
Added placeholders for the quora and medium social icons
|
Thanks!
Regards,
Mayank
…On Fri, Feb 22, 2019, 8:09 PM Maruan ***@***.***> wrote:
Merged #40 <#40> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA3ZCgb692GdvmAqmVewGqpSAyXQZi81ks5vQJS2gaJpZM4bIO_P>
.
|
esteng
pushed a commit
to esteng/al-folio
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.