Changed prettier workflow to actually apply changes #2806
+9
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Araújo <george.gcac@gmail.com>
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George Araújo <george.gcac@gmail.com>
george-gca
force-pushed
the
new_prettier_workflow
branch
from
0203b6c to
ed1e8b0
Compare
Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
alshedivat
approved these changes
Dec 25, 2024
Comment on lines
-22
to
-23
| - name: Install Prettier 💾 | ||
| run: npm install --save-dev --save-exact prettier @shopify/prettier-plugin-liquid |
There was a problem hiding this comment.
looks like prettier code formatter fails. you may need to keep this step.
|
It is failing in the checkout code part, and honestly idk why. I even asked for help in actions/checkout#1326 (comment). |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'll try to come back to this later. Last time that I checked it was failing on the pull action, which was out of my control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.