Issue 105 : Dark Mode + Theming #118 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2020 19:39
* Themes scss file created with default color scheme and dark color scheme. * Logic for managing dark mode toggle added. * Modified existing scss/html to work with theme toggling.
alshedivat
requested changes
Oct 3, 2020
There was a problem hiding this comment.
Thanks for your contribution! Looks great, especially the theming feature.
One request before I merge: could you make the dark mode an optional feature (off by default)?
To do that, simply add a variable to _config.yml called enable_dark_mode (similar to other optional features) and make sure that dark-mode specific code is loaded only when enable_dark_mode=true.
|
Sounds good I'll make the change by Wednesday latest. |
* Added the requested option of disabling/enabling dark mode via config files.
|
Made the requested change. If you require a rebased version I can make another pull request using the master branch : https://github.com/Jongwoo-Shim/al-folio/tree/master |
alshedivat
approved these changes
Oct 5, 2020
searhein
added a commit
to searhein/searhein.github.io
that referenced
this pull request
Dec 31, 2020
* 'master' of https://github.com/alshedivat/al-folio: Minor fixes of the dark mode + automatic equation numbering (alshedivat#160) Update text color in navbar in dark mode (alshedivat#154) add wide screen configuration (alshedivat#157) Support more accurate author annotation (alshedivat#156) Update README, change theme-color in _themes.scss (alshedivat#153) Move GA script to head.html (alshedivat#140) Update _base.scss (alshedivat#137) Adding back the description on the About page (alshedivat#136) Add keybase badge (alshedivat#132) add website (alshedivat#134) Issue 105 : Dark Mode + Theming alshedivat#118 (alshedivat#119) Updated Google Analytics code (alshedivat#123) Github MetaData (alshedivat#121) Added Twitter Card Support (alshedivat#120) Fix issues with loading scripts (alshedivat#117) Switch to MathJax 3.x. Fixes alshedivat#115. Update README.md Update README.md # Conflicts: # _config.yml # _includes/head.html # _includes/header.html # _sass/_base.scss # _sass/_variables.scss
song-qun
pushed a commit
to song-qun/song-qun.github.io
that referenced
this pull request
Mar 19, 2021
* Dark Mode + Theming * Themes scss file created with default color scheme and dark color scheme. * Logic for managing dark mode toggle added. * Modified existing scss/html to work with theme toggling. * Fixed hover issues * Added enable_darkmode to configs. * Added the requested option of disabling/enabling dark mode via config files.
antchristou
pushed a commit
to antchristou/antchristou.github.io
that referenced
this pull request
Nov 20, 2023
* Dark Mode + Theming * Themes scss file created with default color scheme and dark color scheme. * Logic for managing dark mode toggle added. * Modified existing scss/html to work with theme toggling. * Fixed hover issues * Added enable_darkmode to configs. * Added the requested option of disabling/enabling dark mode via config files.
siantonelli
pushed a commit
to siantonelli/siantonelli.github.io
that referenced
this pull request
Oct 26, 2024
* Dark Mode + Theming * Themes scss file created with default color scheme and dark color scheme. * Logic for managing dark mode toggle added. * Modified existing scss/html to work with theme toggling. * Fixed hover issues * Added enable_darkmode to configs. * Added the requested option of disabling/enabling dark mode via config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created separate branch for dark mode, as I maybe submitting another PR.