Issues on Medium links in Search

[strivn]

Have you checked that your issue isn't already filed?

• I read through FAQ and searched through the past issues, none of which addressed my issue.
• Yes, I have checked that this issue isn't already filed.

Bug description

Medium links in Search redirects to asset file instead of Medium and may be duplicated

How to reproduce the bug

Steps to reproduce:

1. Use the template and add Medium link through _config.yml
2. Launch the site, and use the search function to search for the post

Expected output:

1. Link in search will redirect to the actual medium post, e.g. medium.com/user/medium-title
2. Each medium post will be shown exactly once (no duplicates)

Actual output:

1. Link in search will redirect to the actual medium post, e.g. example.github.io/medium-year/medium-title
2. A medium post may be shown twice (duplicated)

What operating system are you using?

Not applicable (e.g. you're using GitHub Pages or other hosting)

Where are you seeing the problem on?

Deployed site

More info

Related to the question #2464

Example output:

[strivn]

I'm unfamiliar with Jekyll, but from what I've tested out, it seems that the duplicate issue originates in search.liquid looping over both site.collections and site.posts.

al-folio/_includes/scripts/search.liquid

Lines 75 to 86 in afc56cc

	{%- for post in site.posts -%}
	{
	{%- assign title = post.title | escape -%}
	id: "post-{{ title | slugify }}",
	title: "{{ title }}",
	description: "{{ post.description | strip_html | strip_newlines | escape }}",
	section: "Posts",
	handler: () => {
	window.location.href = "{{ post.url | relative_url }}";
	},
	},
	{%- endfor -%}

al-folio/_includes/scripts/search.liquid

Lines 87 to 106 in afc56cc

	{%- for collection in site.collections -%}
	{%- for item in collection.docs -%}
	{
	{%- if item.inline -%}
	{%- assign title = item.content | remove: '<p>' | remove: '</p>' | escape | strip -%}
	{%- else -%}
	{%- assign title = item.title | escape -%}
	{%- endif -%}
	id: "{{ collection.label }}-{{ title | slugify }}",
	title: '{{ title | emojify }}',
	description: "{{ item.description | strip_html | strip_newlines | escape }}",
	section: "{{ collection.label | capitalize }}",
	{%- unless item.inline -%}
	handler: () => {
	window.location.href = "{{ item.url | relative_url }}";
	},
	{%- endunless -%}
	},
	{%- endfor -%}
	{%- endfor -%}

The cause seems to be due posts are also considered as collections. I'm not sure how to see exactly what site contains, but I assumed so because looking at external_posts.rb, posts are added into collections.

al-folio/_plugins/external-posts.rb

Lines 44 to 57 in afc56cc

	def create_document(site, source_name, url, content)
	slug = content[:title].downcase.strip.gsub(' ', '-').gsub(/[^\w-]/, '')
	path = site.in_source_dir("_posts/#{slug}.md")
	doc = Jekyll::Document.new(
	path, { :site => site, :collection => site.collections['posts'] }
	)
	doc.data['external_source'] = source_name
	doc.data['title'] = content[:title]
	doc.data['feed_content'] = content[:content]
	doc.data['description'] = content[:summary]
	doc.data['date'] = content[:published]
	doc.data['redirect'] = url
	site.collections['posts'].docs << doc
	end

Additionally, the function create_document in external_posts.rb doesn't seem to define the url as the external url and instead stores it in redirect. Since in search.liquid the url is used instead of redirect, search doesn't work as expected.

---

Hope this helps. Let me know if there's anything I can assist to fix (not sure about how best to approach). Thanks!

[strivn]

Thanks!