fix: initialize logger immediately instead of using the autofac module

fixes #1
alsami · Oct 7, 2019 · 9bca8ce · 9bca8ce
1 parent a223073
commit 9bca8ce
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/src/Serilog.Extensions.Autofac.DependencyInjection/ContainerBuilderExtensions.cs b/src/Serilog.Extensions.Autofac.DependencyInjection/ContainerBuilderExtensions.cs
@@ -10,14 +10,10 @@ public static ContainerBuilder RegisterSerilog(this ContainerBuilder builder, st
             LogEventLevel logEventLevel = LogEventLevel.Debug, string outputTemplate = Constants.DefaultLogTemplate)
         {
             if (string.IsNullOrWhiteSpace(logPath))
-            {
                 throw new ArgumentNullException(nameof(logPath));
-            }
 
             if (string.IsNullOrWhiteSpace(outputTemplate))
-            {
                 throw new ArgumentNullException(nameof(outputTemplate));
-            }
 
             return RegisterSerilogInternal(builder,
                 Constants.DefaultLoggerConfiguration(logPath, outputTemplate, logEventLevel));
@@ -30,11 +26,12 @@ private static ContainerBuilder RegisterSerilogInternal(this ContainerBuilder bu
             LoggerConfiguration loggerConfiguration)
         {
             if (loggerConfiguration == null)
-            {
                 throw new ArgumentNullException(nameof(loggerConfiguration));
-            }
 
-            builder.RegisterModule(new SerilogModule(loggerConfiguration));
+            Log.Logger = loggerConfiguration
+                .CreateLogger();
+
+            builder.RegisterModule<SerilogModule>();
 
             return builder;
         }

diff --git a/src/Serilog.Extensions.Autofac.DependencyInjection/SerilogModule.cs b/src/Serilog.Extensions.Autofac.DependencyInjection/SerilogModule.cs
@@ -6,18 +6,8 @@ namespace Serilog.Extensions.Autofac.DependencyInjection
 {
     internal class SerilogModule : Module
     {
-        private readonly LoggerConfiguration loggerConfiguration;
-
-        public SerilogModule(LoggerConfiguration loggerConfiguration)
-        {
-            this.loggerConfiguration = loggerConfiguration;
-        }
-
         protected override void Load(ContainerBuilder builder)
         {
-            Log.Logger = this.loggerConfiguration
-                .CreateLogger();
-
             builder.Register(_ => new LoggerFactory(new ILoggerProvider[] {new SerilogLoggerProvider()}))
                 .As<ILoggerFactory>()
                 .SingleInstance();