-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcm: Add MSBITS subformat options #342
pcm: Add MSBITS subformat options #342
Conversation
Allow userspace applications to select subformats easily just like in snd_pcm_format_t case - by string conversion. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Related alsa-utils PR: aplay: Add option for specifying subformat. |
This will be paired with relevant kernel updates, posting as RFC for now. Will link the alsa-devel thread once the patchset is there. The patchset ALSA/ASoC: hda: Address format selection limitations and ambiguity has been posted on alsa-devel. |
628ad04
to
bb90b8c
Compare
Changes in v2:
|
Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Update snd_pcm_subformat_t getters and setters so they no longer throw warnings when building. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
bb90b8c
to
1de598f
Compare
Bumping the subject. Dropping [RFC] as the kernel series [PATCH v5 00/16] ALSA/ASoC: hda: Address format selection limitations and ambiguity has been merged into Takashi's for-next. |
Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. Closes: #342 Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Update snd_pcm_subformat_t getters and setters so they no longer throw warnings when building. Closes: #342 Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. As a preparation step introduce
snd_pcm_subformat_value()
for easy name-to-subformat conversions.While at it, fix few warnings that pop up in subformat-related code during compilation.