Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/gyp: upgrade to 20190716 #12144

Closed
wants to merge 1 commit into from
Closed

testing/gyp: upgrade to 20190716 #12144

wants to merge 1 commit into from

Conversation

OTLabs
Copy link
Contributor

@OTLabs OTLabs commented Nov 20, 2019 •
edited
Loading

  • Add cleanup_srcdir()

@probot-autolabeler probot-autolabeler bot added the R-testing Testing repository label Nov 20, 2019
@OTLabs
Copy link
Contributor Author

OTLabs commented Nov 20, 2019

@maxice8 could you please review proposed upgrade and changes? Thank you!

@OTLabs OTLabs changed the title testing/gyp: upgrade to 20190716 WiP testing/gyp: upgrade to 20190716 Nov 21, 2019
@maxice8
Copy link
Contributor

maxice8 commented Nov 21, 2019

Can you check that stuff like telegram-desktop still work ? I also did a gyp to python3 conversion once but telegram-desktop failed to build

@OTLabs
Copy link
Contributor Author

OTLabs commented Nov 21, 2019

I will check the possibility to switch to python3 on telegram-desktop, thank you for a tip. Meanwhile I have refactored the PR to update gyp to latest version and added cleanup_srcdir() and removed switch to python3.

JFYI, I was able to run all tests except this one: test/generator-output/gyptest-actions.py

@OTLabs OTLabs changed the title WiP testing/gyp: upgrade to 20190716 testing/gyp: upgrade to 20190716 Nov 21, 2019
@OTLabs
testing/gyp: upgrade to 20190716
2cdbe64 
- Add cleanup_srcdir()
maxice8
maxice8 requested changes Nov 21, 2019
View reviewed changes
testing/gyp/APKBUILD Show resolved Hide resolved
@andypost andypost mentioned this pull request Nov 21, 2019
Closed
@algitbot
Copy link

Merged in 0b4fa7f by @maxice8. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Nov 21, 2019
@OTLabs OTLabs deleted the gyp branch November 21, 2019 20:03
@repo-lockdown
Copy link

repo-lockdown bot commented Jan 3, 2020

This repository does not accept Pull Requests (PR) anymore. Development has moved to https://gitlab.alpinelinux.org/alpine/aports Please signup and create a Merge Request (MR) instead. Sorry for the inconvenience caused.

@repo-lockdown repo-lockdown bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxice8 maxice8 maxice8 requested changes

Assignees
No one assigned
Labels
R-testing Testing repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OTLabs @maxice8 @algitbot