-
Notifications
You must be signed in to change notification settings - Fork 61
Fix cross compilation issue #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to set CARGO_TARGET_ARM_UNKNOWN_LINUX_GNUEABIHF_LINKER and compile with --target=arm-unknown-linux-gnueabihf working on optimizer_builder.py
ruairimoran
reviewed
May 7, 2025
ruairimoran
reviewed
May 7, 2025
ruairimoran
approved these changes
May 7, 2025
Collaborator
ruairimoran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
codegen
Code generation
docs
improvement of documentation
raspberry pi
Raspberry Pi target
test
Unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress
Main Changes
Firstly, each cargo package has its own
.cargo/config.tomlfile with the following contents:Then we can cross-compile with
cargo build --target=arm-unknown-linux-gnueabihf.Secondly, we now cross-compile for RPi on GitHub Actions (see
test/test_raspberry_pi.pyandci.yml).Lastly, I tested this on a Raspberry Pi and it works.
Other changes:
Associated Issues
We're still getting an error when cross-compiling with
.with_build_python_bindings(), but we'll address it in a separate PR (see issue #369).TODOs
CHANGELOG(s)CHANGELOG,Cargo.tomlandVERSION)