-
Notifications
You must be signed in to change notification settings - Fork 7
[Beautification] Re-themed ENTIRE Project #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…eep the code clean for when I add MySQL support
Hi! First of all thanks for that great job, it's really nice to see people participating to the project (even more as I barely support the webinterface). I've made a list of a few points I'd like to discuss in your pull request:
Finally, basically all the projects has been changed as the code has been auto indented, so I might have missed a few changes, but I think that's it :) Thanks again for you work, I'd be glad to pull these and upload it to spigot once the issues are resolved. Friendly, P.S: Do you have this version in production and already thoroughly tested it or do I need to beta test it before uploading it to the whole spigot? |
Hi, So for the your setup security, I URGE you to CHANGE them. |
Oh, sorry, I did those before actually reading your msgs. And the login infos are once again gone. Whew! Thanks for the heads up! That could've cost me my server! Replies To Points:
The code wasn't auto-indented, no sir, no. That was so confusing lmao. I was struggling to understand the code so I decided to go thru every single file that I needed to mess with, indent & format them, and THEN begin coding on them. Lmao I can't stand it when developers don't indent their code, like the project that I'm currently working on; a custom Google Material Design template for NamelessMC 2.0. I'm glad you enjoyed it. Please reply with anything else you need to say, and I'll go over these issues ASAP, although I have school too :P P.S. PLEASE remove the message where u linked to my database credentials... Derp... Lmao. Tysm! :D Also, checkout the SpigotMC page I made for the plugin last night. You seemed to be inactive and hadn't replied to my GitHub pull request (as far as I knew at the time) so I decided to make a SpigotMC resource posting of my version of the web interface. If you want, I can take it down, but I don't see any issues with it being up as I credited you in any way that I could. I tested things as I went, although I didn't go crazy testing however, so I urge you to double check everything for any possible mistakes that I may have made. :P :D <3 Also, yea, don't upload it to SpigotMC until all the issues are accounted for. Thanks! |
Title says it all. I heard some people complaining about how they couldn't use the native BAT Web Interface because it was so ugly, so I decided to make it really pretty. I have everything setup to be based off of NamelessMC so everything matches up with NamelessMC's style. Enjoy! <3 :O :D
Screenshots:



