Skip to content

Commit

Permalink
Fix: (ement-room-list-next-unread) Infinite loop
Browse files Browse the repository at this point in the history
Thanks to Visuwesh (@Vizs) and <@mrtnmrtn:matrix.org>.
  • Loading branch information
alphapapa committed Aug 13, 2023
1 parent 60e9a50 commit dbe2212
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.org
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ Note that, while ~matrix-client~ remains usable, and probably will for some time
+ Call external browser for SSO login page. (JavaScript is usually required, which EWW doesn't support, and loading the page twice seems to change state on the server that causes the SSO login to fail, so it's best to load the page in the external browser directly).
+ Clean up SSO server process after two minutes in case SSO login fails.
+ Don't stop syncing if an error is signaled while sending a notification.
+ Command ~ement-room-list-next-unread~ could enter an infinite loop. (Thanks to [[https://github.com/vizs][Visuwesh]] and ~@mrtnmrtn:matrix.org~.)

** 0.10

Expand Down
3 changes: 2 additions & 1 deletion ement-room-list.el
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,8 @@ left."
(ement-room-goto-fully-read-marker)
(cl-return t))
else do (forward-line 1)
while (> (line-number-at-pos) starting-line))
while (and (not (eobp))
(> (line-number-at-pos) starting-line)))
;; No more unread rooms.
(message "No more unread rooms")))

Expand Down

0 comments on commit dbe2212

Please sign in to comment.