Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register job directories after creating them #65

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

GlassOfWhiskey
Copy link
Member

Using $(runtime.outdir) directly as an output glob in a CWL workflow was causing an error, due to the fact that the location had not been registered in the StreamFlow FS. This commit solves the issue by registering job directories right after their creation.

Using $(runtime.outdir) directly as an output glob in a CWL workflow was
causing an error, due to the fact that the location had not been
registered in the StreamFlow FS. This commit solves the issue by
registering job directories right after their creation.
@codecov-commenter
Copy link

Codecov Report

Base: 65.28% // Head: 65.22% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (0692195) compared to base (8d5afea).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   65.28%   65.22%   -0.07%     
==========================================
  Files          73       73              
  Lines        8631     8647      +16     
  Branches     2048     2052       +4     
==========================================
+ Hits         5635     5640       +5     
- Misses       2638     2652      +14     
+ Partials      358      355       -3     
Impacted Files Coverage Δ
streamflow/workflow/step.py 79.73% <100.00%> (+0.10%) ⬆️
streamflow/deployment/connector/queue_manager.py 34.51% <0.00%> (-3.49%) ⬇️
streamflow/data/stream.py
streamflow/data/aiotarstream.py
streamflow/deployment/aiotarstream.py 37.82% <0.00%> (ø)
streamflow/deployment/stream.py 80.35% <0.00%> (ø)
streamflow/workflow/combinator.py 90.98% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GlassOfWhiskey GlassOfWhiskey merged commit ea59592 into master Feb 6, 2023
@GlassOfWhiskey GlassOfWhiskey deleted the register-job-dirs branch February 6, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants