Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better job naming strategy for CWL #51

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Better job naming strategy for CWL #51

merged 1 commit into from
Jan 24, 2023

Conversation

GlassOfWhiskey
Copy link
Member

@GlassOfWhiskey GlassOfWhiskey commented Jan 24, 2023

This commit renames jobs as step_name/job_id, instead of naming them
with a randomly generated string. This simplifies debugging and log
interpretation. Plus, the workflow persistent id is included in the Job
object, allowing the scheduler to take decisions based on the entire
workflow shape.

This commit renames jobs as step_name/job_id, instead of naming them
with a randomly generated string. This simplifies debugging and log
interpretation. Plus, the workflow persistent id is included in the Job
object, allowing the scheduler to take decisions based on the entire workflow
shape.
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Base: 63.10% // Head: 63.14% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (5077d2f) compared to base (022261a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   63.10%   63.14%   +0.03%     
==========================================
  Files          73       73              
  Lines        8590     8591       +1     
  Branches     2035     2035              
==========================================
+ Hits         5421     5425       +4     
+ Misses       2813     2812       -1     
+ Partials      356      354       -2     
Impacted Files Coverage Δ
streamflow/cwl/translator.py 86.14% <ø> (ø)
streamflow/recovery/failure_manager.py 30.40% <ø> (ø)
streamflow/core/workflow.py 76.05% <100.00%> (+0.08%) ⬆️
streamflow/workflow/step.py 75.54% <100.00%> (ø)
streamflow/scheduling/scheduler.py 77.95% <0.00%> (+0.78%) ⬆️
streamflow/workflow/combinator.py 90.16% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GlassOfWhiskey GlassOfWhiskey merged commit 556654c into master Jan 24, 2023
@GlassOfWhiskey GlassOfWhiskey deleted the job-names branch January 24, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants