-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved ssh retry mechanism #501
Open
LanderOtto
wants to merge
16
commits into
master
Choose a base branch
from
fix/retry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanderOtto
force-pushed
the
fix/retry
branch
12 times, most recently
from
July 18, 2024 22:17
d19da72
to
a387d0a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 69.94% 69.90% -0.04%
==========================================
Files 87 87
Lines 10882 10889 +7
Branches 2548 2548
==========================================
+ Hits 7611 7612 +1
- Misses 2798 2802 +4
- Partials 473 475 +2 ☔ View full report in Codecov by Sentry. |
LanderOtto
force-pushed
the
fix/retry
branch
16 times, most recently
from
August 5, 2024 08:58
7d97e06
to
e82635b
Compare
LanderOtto
force-pushed
the
fix/retry
branch
2 times, most recently
from
September 20, 2024 11:55
cf1268f
to
8a57839
Compare
LanderOtto
force-pushed
the
fix/retry
branch
8 times, most recently
from
September 25, 2024 11:53
7b6b3e8
to
2736cb7
Compare
…ism involves only when the connection was opened. Now, it covers both connection opening and connection communication exceptions.
LanderOtto
force-pushed
the
fix/retry
branch
2 times, most recently
from
October 4, 2024 10:51
2a28510
to
14d0cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the retry mechanism to be more resilent. Before this commit, the mechanism involves only the connection opening. Now, it covers both connection opening and connection communication exceptions.
Moreover, the
close
method of theSSHContext
class was fixed calling the asynchronouswait_closed
method of theasyncssh
library and writing theEOF
when the writer stream is closed. It avoids to re-open the connection before that previous one was completely closed.Finally, three logging messages were fixed. A Docker
DEBUG
logging message has new line at the end of the message. The step exit status was in lowercase, but in StreamFlow the status is showed in uppercase. The logging of commands executed remotely thoughSSHConnector
were not printed because there was an wrong operation association between an inlineif-else
and two f-strings.