Fix scheduler validation path #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static validation of scheduler classes was not working for two reasons. First, the `schemas` folder in the `scheduling` package was not loaded in the release archive. Plus, scheduler config files were not loader by the validator prior to check the configuration. This commit fixes both issues.
Codecov ReportBase: 63.09% // Head: 63.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 63.09% 63.11% +0.02%
==========================================
Files 73 73
Lines 8571 8590 +19
Branches 2035 2035
==========================================
+ Hits 5408 5422 +14
- Misses 2808 2809 +1
- Partials 355 359 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static validation of scheduler classes was not working for two reasons. First, the
schemasfolder in theschedulingpackage was not loaded in the release archive. Plus, scheduler config files were not loader by the validator prior to check the configuration. This commit fixes both issues.