Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed InplaceUpdateRequirement in the distributed executions #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented May 31, 2024

This commit invalidates the instances of a data in the StreamFlow filesystem, when a step has a InplaceUpdateRequirement.
The valid data is only the data present in the location of the step which execute the inplace update, thus all the other data instances in other locations must be invalidated.
Invalidation is necessary because the old data in another location should not be used by next steps.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.14%. Comparing base (fd24b5b) to head (2e889d5).

Files Patch % Lines
streamflow/cwl/utils.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   70.15%   70.14%   -0.01%     
==========================================
  Files          84       84              
  Lines       10600    10605       +5     
  Branches     2509     2512       +3     
==========================================
+ Hits         7436     7439       +3     
- Misses       2705     2712       +7     
+ Partials      459      454       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant