Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scheduler timeout in Python<3.11 #449

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented May 7, 2024

This commit fixes a bug using the timeout feature of the scheduler with Python version older than 3.11.
The asyncio.wait_for method raises two different Timeout exceptions depending on the Python version (see doc). Starting from Python 3.11, Timeout built-in exception is raised, while asyncio.exceptions.Timeout exception is raised with previous Python versions.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.18%. Comparing base (14c35a6) to head (e656cb7).

Files Patch % Lines
streamflow/scheduling/scheduler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          83       83           
  Lines       10591    10591           
  Branches     2504     2504           
=======================================
  Hits         7433     7433           
  Misses       2702     2702           
  Partials      456      456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit 9771d02 into master May 7, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/timeout branch May 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants