Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed retrieval of location hardware in the SSHConnector class #424

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Apr 1, 2024

This commit introduces some changes in the SSHConnector class:

  • remove the hardwareCache attribute
  • improve the performance creating tasks through the asyncio.create_task function to retrieve the hardware of each location. Before this commit, the hardware retrieval of each location was done sequentially.
  • reduce the number of remote communications to retrieve location hardware. Before this commit, there were five communications, now only one.
  • reduce the number of remote communications to check for existing directories in one communication, instead of initiating a dedicated communication for each directory

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.09%. Comparing base (eba599c) to head (695e8ef).

Files Patch % Lines
streamflow/deployment/connector/ssh.py 89.74% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   70.11%   70.09%   -0.02%     
==========================================
  Files          83       83              
  Lines       10564    10567       +3     
  Branches     2496     2499       +3     
==========================================
  Hits         7407     7407              
- Misses       2702     2704       +2     
- Partials      455      456       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: GlassOfWhiskey <iacopo.c92@gmail.com>
@LanderOtto LanderOtto force-pushed the feat/removed-ssh-cache branch 3 times, most recently from 5841946 to a55ef2d Compare April 1, 2024 23:57
@LanderOtto LanderOtto changed the title Removed hardwareCache attribute in the SSHConnector class Changed retrieval of location hardware in the SSHConnector class Apr 2, 2024
@GlassOfWhiskey GlassOfWhiskey merged commit 10088bb into master Apr 5, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the feat/removed-ssh-cache branch April 5, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants