Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested Location objects #383

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

GlassOfWhiskey
Copy link
Member

When using ConnectorWrapper instances, a Location object can wrap another Location object from the inner Connector. This information is now stored on each Location object through the wraps field and propagated to all the derived Location objects in the StreamFlow logic.

When using `ConnectorWrapper` instances, a `Location` object can wrap
another `Location` object from the inner `Connector`. This information
is now stored on each `Location` object through the `wraps` field and
propagated to all the derived `Location` objects in the StreamFlow
logic.
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8b0d6f0) 69.17% compared to head (9c5d74d) 69.16%.

Files Patch % Lines
streamflow/deployment/utils.py 75.00% 1 Missing and 1 partial ⚠️
streamflow/deployment/connector/queue_manager.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   69.17%   69.16%   -0.01%     
==========================================
  Files          83       83              
  Lines       10519    10523       +4     
  Branches     2486     2488       +2     
==========================================
+ Hits         7276     7278       +2     
- Misses       2785     2786       +1     
- Partials      458      459       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit 7ff5aa4 into master Feb 16, 2024
34 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the location-wrappers branch February 16, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant