Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed get method of RemotePathMapper #343

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fixed get method of RemotePathMapper #343

merged 1 commit into from
Jan 1, 2024

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Jan 1, 2024

This commit fixes the get method of the RemotePathMapper class when trying to access a location not yet registered in the StreamFlow filesystem.
In particular, this commit fixes issue #342, probably caused by a regression introduced by PR #328.

@LanderOtto LanderOtto changed the title Fixed get_locations Fixed get method of RemotePathMapper Jan 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (955f43d) 67.17% compared to head (7019b15) 67.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   67.17%   67.18%           
=======================================
  Files          82       82           
  Lines       10277    10277           
  Branches     2432     2432           
=======================================
+ Hits         6904     6905    +1     
+ Misses       2949     2948    -1     
  Partials      424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit afbe1ff into master Jan 1, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/get_loc branch January 1, 2024 19:50
@GlassOfWhiskey GlassOfWhiskey changed the title Fixed get method of RemotePathMapper Fixed get method of RemotePathMapper Jan 1, 2024
@LanderOtto LanderOtto restored the fix/get_loc branch January 15, 2024 10:50
@LanderOtto LanderOtto deleted the fix/get_loc branch January 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using the same path for outdir and for workdir of local deployment
3 participants