Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs #333

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Fixed some bugs #333

merged 11 commits into from
Jan 31, 2024

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Dec 24, 2023

This commit fixes several problems.

  • The asyncio.gather coroutine used in the is_available method of the ObjectToken and ListToken classes were never awaited
  • In the Reduce size of database metadata #338 PR, the command table was not renamed in the get_reports query of the SqliteDatabase class
  • Changed the style of variable names from CamelCase to snake_case
  • Fixed typo of an attribute name in the LoopCombinatorStep class

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e340e17) 67.55% compared to head (d595916) 67.55%.

Files Patch % Lines
streamflow/main.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files          83       83           
  Lines       10475    10475           
  Branches     2475     2475           
=======================================
  Hits         7076     7076           
  Misses       2960     2960           
  Partials      439      439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto changed the title Fixed token availability Fixed some errors Jan 15, 2024
@LanderOtto LanderOtto changed the title Fixed some errors Fixed some bugs Jan 21, 2024
@GlassOfWhiskey GlassOfWhiskey merged commit cc640ac into master Jan 31, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/token-availability branch January 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants